feat(router): lua validate an expression against a schema #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
chronolaw
reviewed
Feb 13, 2023
chronolaw
changed the title
chronolaw
reviewed
Feb 13, 2023
chronolaw
reviewed
Feb 14, 2023
chronolaw
approved these changes
Feb 14, 2023
|
ping @dndx |
chronolaw
reviewed
Mar 20, 2023
|
ping @pluveto @chronolaw |
|
This PR is ready for merge, it just needs a final review. |
|
@chronolaw Please perform the final review and let's merge. |
chronolaw
approved these changes
Apr 7, 2023
|
We should also add a description in |
done |
chronolaw
reviewed
Apr 23, 2023
dndx
requested changes
Apr 23, 2023
chronolaw
force-pushed
the
feat/validate
branch
2 times, most recently
from
ec405ba
to
3b0f471
Compare
|
I applied this PR to v1.0.5, and found that all ci tests passed. I think perhaps some dependency upgrade causes the regex behavior is different from v 1.0.5. After some tries, I found that the dependency |
|
In Rust regex crate, 1.8.0 changed a escape behavior, see: rust-lang/regex#501. |
chronolaw
force-pushed
the
feat/validate
branch
4 times, most recently
from
437a5d4
to
e5b5c30
Compare
Co-authored-by: Chrono <[email protected]>
chronolaw
force-pushed
the
feat/validate
branch
2 times, most recently
from
2c0648c
to
5c15238
Compare
dndx
approved these changes
May 10, 2023
dndx
reviewed
May 10, 2023
dndx
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature to validate an expression against a given schema.
syntax: ok, err = r.validate(schema, expr)
context: any
Returns
truewhen the expression is valid.If the expression is invalid,
niland a string describing the reason will be returned.KAG-1524