Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting url_background to null causes collection to be skipped #84

Closed
PleaseStopAsking opened this issue Mar 5, 2021 · 4 comments · Fixed by #83
Closed

Setting url_background to null causes collection to be skipped #84

PleaseStopAsking opened this issue Mar 5, 2021 · 4 comments · Fixed by #83
Assignees
Labels
bug Bug is with Plex Meta Manager

Comments

@PleaseStopAsking
Copy link

I have set some of my collection backgrounds to a null value when I am unable to locate a nice enough image to use which previously prevented PMM from using whichever image it choose pre 1.3.0. With the latest release, PMM now skips the collection entirely with the message Collection Error: url_background attribute is blank.

The workaround would be to remove the url_background parameter from all collections that do not leverage it but I prefer to leave it in and set to null so that I can quickly search for url_background: null in the future and replace when I come across images I like.

With this said, is this new behavior as designed or unintentional?

@meisnate12
Copy link
Member

Thats the intended behavior. If you use an attribute but leave it blank I'm assuming you forgot to fill something in so I wanted a message for the user.

@meisnate12
Copy link
Member

well after rereading your question the intended behavior is to skip the image not the collection let me look at this closer

@meisnate12 meisnate12 self-assigned this Mar 5, 2021
@meisnate12 meisnate12 added the bug Bug is with Plex Meta Manager label Mar 5, 2021
@PleaseStopAsking
Copy link
Author

well after rereading your question the intended behavior is to skip the image not the collection let me look at this closer

Let me know if anything is needed from my end for validating the issue.

meisnate12 added a commit that referenced this issue Mar 5, 2021
@meisnate12
Copy link
Member

fix is in develop is you want to test

@meisnate12 meisnate12 mentioned this issue Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug is with Plex Meta Manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants