Add custom color controls #14
Conversation
Also moved block styles to separate stylesheets (should have been a separate commit)
Updates to CSS
| setAttributes( { commitMessage: data.commit.message } ); | ||
| } ) | ||
| .catch( error => { | ||
| setAttributes( { commitSha: "Please enter a valid commit ID." } ); |
There was a problem hiding this comment.
Wrapping the text constant with a translation function would make it even better.
There was a problem hiding this comment.
I plan to add translation in a different PR: I need to go through the entire plugin and make sure all strings are internationalized and using the correct text-domain, and at this point it makes more sense to me to do that all at once to ensure consistency.
| <div id="gh-commit-widget-controls"> | ||
| <fieldset> | ||
| <legend className="blocks-base-control__label"> | ||
| Commit Hash |
|
Thanks, @KokkieH! Changes look great. The approach we use in WCCOM implies that developer writes testing instructions for other developers on how to repeat/see what was done and how to make sure it works as expected. Optionally, you can add those instructions in this PR to train writing instructions of this kind. |
Thanks for the feedback. I'm still working on this one, though, so it's really just a stub at this point. I plan to flesh out the PR description once it's ready to ship :) |
Fixes #11