-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render block content #10
Open
KokkieH
wants to merge
14
commits into
main
Choose a base branch
from
render-block-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moved block styles to separate stylesheets (should have been a separate commit)
KokkieH
added
[Status] Needs review
[Status] Ready to merge
and removed
[Status] In progress
labels
Feb 28, 2022
Thanks, @KokkieH! The changes look great. The only thing I want to highlight is that we should remove built sources from repo by adding build folder into a |
Thanks for the tip. I think 1db80d6 should do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
block.json
filesave
function to display block content on front endNext steps:
edit
andsave
functions. Is it possible to assign the output to a single attribute so we can then just re-use that one attribute?.editor-styles-wrapper
from overriding my custom stylesheet for the block in the editor, but it seems the block colour controls don't have any effect on text added inside the<h3>
or<a>
elements.But it works, so this is ready to ship.