Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typos and minor quality checks #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed typos and minor quality checks #5

wants to merge 3 commits into from

Conversation

leovarmak
Copy link

@leovarmak leovarmak commented Feb 26, 2019 •
edited
Loading

Fixes #4 and some typo corrections

@leovarmak leovarmak mentioned this pull request Feb 26, 2019
Open
@leovarmak leovarmak changed the title fixed typos fixed typos and minor quality checks Feb 26, 2019
HimanshuSingh2308
HimanshuSingh2308 approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@HimanshuSingh2308 HimanshuSingh2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work !!

@ramisra ramisra self-requested a review March 1, 2019 15:46
ramisra
ramisra reviewed Mar 1, 2019
View reviewed changes
Copy link
Contributor

@ramisra ramisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

HimanshuSingh2308
HimanshuSingh2308 approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@HimanshuSingh2308 HimanshuSingh2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all are typo changes good to go

akhilkoinex
akhilkoinex approved these changes Mar 6, 2019
View reviewed changes
Copy link

@akhilkoinex akhilkoinex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are required changes in content. @leovarmak Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HimanshuSingh2308 HimanshuSingh2308 HimanshuSingh2308 approved these changes

@akhilkoinex akhilkoinex akhilkoinex approved these changes

@ramisra ramisra ramisra approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leovarmak @ramisra @akhilkoinex @HimanshuSingh2308