-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add stdc++fs to link path to compatible with gcc #88
base: master
Are you sure you want to change the base?
Conversation
It's not necessary for our use case. |
hmm..that's interesting. I thought it works because I use gcc 8.3(latest on official Ubuntu 1804) with this fix to format 10,000+ files correctly. Anyway, thanks for your check and good code. |
@winest you could run the test suite. |
@tammela
My environment:
|
Confirmed that apparently they fixed this issue (segfault on fs lib) in 8.3. I did a PR that addressed the code issues here and made it work in all platforms. Thank you! |
fix: link to stdc++fs when needed as discussed in #88
gcc need to specify libstdc++fs to support when specifying CMAKE_CXX_STANDARD=17
Refer to https://gitlab.kitware.com/cmake/cmake/issues/17834