Added presets (hold_modes) to climate sensor #3821

[mgrom]

Added presets (hold_modes) to climate sensor #3821
and removed thermostatHeatCool as it was partially redundant

[branch-switcher]

Hello @mgrom. The base branch of this pull request has been updated to the dev branch. Please revisit the changes and make sure that there are no conflicts with the new base branch. Thank you for your contributions.

[mgrom]

@Koenkk how to manage changes in zigbee-herdsman-converters that are related to this PR? Should I make them later or now but with some tag or something?

[Koenkk]

@mgrom just make a pr to zigbee-herdsman-converters and mention this pr there, I will merge it after that is merged.

[Koenkk]

/rebase

[Koenkk]

/autorebase

[Koenkk]

Thanks!

[presslab-us]

@mgrom with the removal of thermostatHeatCool there is now no longer a way to set separate heating and cooling temperatures on a thermostat that supports both.

Also the new climate does not use temperature_unit so those of us that use Fahrenheit do not get the right values.

[mgrom]

@presslab-us this wasn't just removal. I've merge it to climate:

const climate = (minTemp=7, maxTemp=30, temperatureStateProperty='occupied_heating_setpoint',
   tempStep=1, systemModes=['off', 'auto', 'heat'], fanModes=[], holdModes=[],
   temperatureLowStateTopic=false, temperatureHighStateTopic=false ) => {
.....

  // use low target temperature
   if (temperatureLowStateTopic) {
       retVal.discovery_payload.temperature_low_state_topic = temperatureLowStateTopic;
       retVal.discovery_payload.temperature_low_state_template = `{{ value_json.occupied_heating_setpoint }}`;
       retVal.discovery_payload.temperature_low_command_topic = 'occupied_heating_setpoint';
   }
   // use high target temperature
   if (temperatureHighStateTopic) {
       retVal.discovery_payload.temperature_high_state_topic = temperatureHighStateTopic;
       retVal.discovery_payload.temperature_high_state_template = `{{ value_json.occupied_heating_setpoint }}`;
       retVal.discovery_payload.temperature_high_command_topic = 'occupied_heating_setpoint';
   }

Regarding temperature it was hardcoded 'C' before, so there was no way to use Fahrenheit either.

[presslab-us]

I haven't looked deeply into it, but for some reason it's not working any more. In Home Assistant it only allows for setting one temperature.

On thermostatHeatCool it did use temperature_unit.

zigbee2mqtt/lib/extension/homeassistant.js

Line 784 in 0db3f3c

temperature_unit: 'C',

[mgrom]

@presslab-us what device are you using? I'll check configuration. Maybe I made some mistake in other place.

[presslab-us]

Thanks @mgrom. I use 3157100 and RC-2000WH. I think I see the issue, here is a snip of the discovery topic:

  "temperature_command_topic": "zigbee2mqtt/lab_thermostat/set/occupied_heating_setpoint",
  "temperature_high_command_topic": "zigbee2mqtt/lab_thermostat/set/occupied_heating_setpoint",
  "temperature_high_state_template": "{{ value_json.occupied_heating_setpoint }}",
  "temperature_high_state_topic": "zigbee2mqtt/lab_thermostat",
  "temperature_low_command_topic": "zigbee2mqtt/lab_thermostat/set/occupied_heating_setpoint",
  "temperature_low_state_template": "{{ value_json.occupied_heating_setpoint }}",
  "temperature_low_state_topic": "zigbee2mqtt/lab_thermostat",
  "temperature_state_template": "{{ value_json.occupied_heating_setpoint }}",
  "temperature_state_topic": "zigbee2mqtt/lab_thermostat",

I believe that for devices that support both high and low state/command, there should not be temperature_command_topic. temperature_state_topic, and temperature_state_template defined.

[mgrom]

@presslab-us ok, I'll make PR to fix it.

[presslab-us]

Great, thanks a lot. I agree that combining them is the right thing. Also if you can add the temperature_unit that would be good, and it will now work for all devices.