Added <operation>_failed logging #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for external tools (like Zigbee2MqttAssistant), this will allow the tool to know when an operation is failed. Koenkk#2223
carldebilly
force-pushed
the
cdb/remove-failed
branch
from
b89675d to
37c7003
Compare
carldebilly
force-pushed
the
cdb/remove-failed
branch
from
09a29d6 to
c85fd63
Compare
carldebilly
force-pushed
the
cdb/remove-failed
branch
4 times, most recently
from
fb6609f to
fd11a30
Compare
carldebilly
force-pushed
the
cdb/remove-failed
branch
from
fd11a30 to
c2afd0e
Compare
|
Thanks, could you also make a PR for the docs? Then this can be merged. |
carldebilly
added a commit
to carldebilly/zigbee2mqtt.io
that referenced
this pull request
Jan 3, 2020
carldebilly
added a commit
to carldebilly/zigbee2mqtt.io
that referenced
this pull request
Jan 3, 2020
Koenkk
pushed a commit
to carldebilly/zigbee2mqtt.io
that referenced
this pull request
Jan 7, 2020
|
Thanks! |
Koenkk
pushed a commit
to Koenkk/zigbee2mqtt.io
that referenced
this pull request
Jan 7, 2020
Koenkk
pushed a commit
to Koenkk/zigbee2mqtt.io
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for external tools (like Zigbee2MqttAssistant), this will allow the tool to know when an operation is failed.
#2223
Added the following:
bridge/bind/<device>&bridge/unbind/<device>can now produce the following logs:device_binddevice_bind_failed🆕device_unbinddevice_unbind_failed🆕bridge/config/remove,bridge/config/force_remove&bridge/config/bancan now produce the following logs:device_removedevice_remove_failed🆕device_force_removedevice_force_remove_failed🆕device_bandevice_ban_failed🆕bridge/group/<group>/(remove|add|remove_all)commands:device_group_adddevice_group_add_failed🆕device_group_removedevice_group_remove_failed🆕device_group_remove_alldevice_group_remove_all_failed🆕TODO: