Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating bindings for devices with a '/' in the name doesn't work. #2250

Closed
sjorge opened this issue Nov 1, 2019 · 5 comments
Closed

Updating bindings for devices with a '/' in the name doesn't work. #2250

sjorge opened this issue Nov 1, 2019 · 5 comments

Comments

@sjorge
Copy link
Contributor

sjorge commented Nov 1, 2019

https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/extension/deviceBind.js#L24

First issue seems to be the mqtt subscription, as it currently accepts + or +/+ wild cards so it will match a device or device/endpoint, if the device name has a '/' it, it will no longer work.

Not sure we can get this to work though, as there is also getIDAndPostfix which strips of the last chunk as the endpoint name (I think). There seems to be a regex in dev.

if this is indeed causing a lot of issues, it might be time to revist the allowing '/' in device and group names. I personally use it a lot because I can easily subscript to all devices in a room, but it does cause a lot of issues frequently.

@sjorge
Copy link
Contributor Author

sjorge commented Nov 1, 2019

Anyway, still having issues with a E1743 I borrowed from a friend for testing.

Even if the source and target do not have a '/' in the name, I am unable to bind it. It also doesn't even log that it received the mqtt topic :s

@Koenkk
Copy link
Owner

Koenkk commented Nov 1, 2019

Fixed in latest dev.

Multiple / doesn't seem to be used a lot, therefore you can encounter some bugs (but issues like this will help to resolve them).

For the E1743 I think you first need to unbind it from group 99 or 0, and maybe it can even be bound to a group and not directly to a device (not sure though).

Closing this as the OP issue has been fixed.

@Koenkk Koenkk closed this as completed Nov 1, 2019
@sjorge
Copy link
Contributor Author

sjorge commented Nov 1, 2019

I'll see if I can borrow the E1743 again at some point to see if I can unbind it from the group... I tried unbinding it from the coordinator with no success either.

For a group... do I just send it the group_id ?

@Koenkk
Copy link
Owner

Koenkk commented Nov 1, 2019

yes

@sjorge
Copy link
Contributor Author

sjorge commented Nov 2, 2019

nvm, somehow a non printable char snuk in :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants