Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for groupID not / wrong reported (e.g. IKEA remote control) #1785

Closed
didiht opened this issue Jul 27, 2019 · 3 comments
Closed

Solution for groupID not / wrong reported (e.g. IKEA remote control) #1785

didiht opened this issue Jul 27, 2019 · 3 comments

Comments

@didiht
Copy link
Contributor

didiht commented Jul 27, 2019

There is a little bug in file 'lib/controller.js' which leads to the debug message '... with groupID undefined ...' in the log file.

line 136:

(message.groupid ? ` with groupID ${message.groupID}` : '') +
                                            ^^^^^^^

has to be corrected to

(message.groupid ? ` with groupID ${message.groupid}` : '') +

With this change the groupID is reported as expected and sniffing is not necessary anylonger.

@didiht didiht mentioned this issue Jul 27, 2019
1 task
@Koenkk
Copy link
Owner

Koenkk commented Jul 27, 2019

Good catch, can you make a pr?

@didiht
Copy link
Contributor Author

didiht commented Jul 27, 2019

Done. I hope I did it in a correct way since I am just learning to play with git.

Koenkk pushed a commit that referenced this issue Jul 27, 2019
@Koenkk
Copy link
Owner

Koenkk commented Jul 27, 2019

looks good, merged it so assume this can be closed, thanks!

@Koenkk Koenkk closed this as completed Jul 27, 2019
Koenkk pushed a commit that referenced this issue Aug 11, 2019
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants