-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TuYa Clusters for TS0505A #237
Conversation
Please see Koenkk/zigbee-herdsman-converters#1661 |
src/zcl/definition/cluster.ts
Outdated
@@ -2087,6 +2089,15 @@ const Cluster: { | |||
{name: 'transtime', type: DataType.uint8}, | |||
], | |||
}, | |||
moveToHueAndSaturationBrightness: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the ZCL: https://github.com/Koenkk/zigbee-herdsman/blob/master/docs/Zigbee%20Cluster%20Library%20Specification%20v7.pdf and command 6 is the moveToHueAndSaturation
and does not provide a brigthness:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know, but unfortunately my TuYa LEDs don't seem follow the standard for whatever reason. Please see attached an image of a packet captured via Wireshark.
The payload contains FF which is the brightness in the end.
Hue: 0x55 = 85
Saturation: 0xFE = 254
Transition time: 0x0000 = 0
Brightness: 0xFF = 255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case change moveToHueAndSaturationBrightness
to tuyaMoveToHueAndSaturationBrightness
Note to self: after this merge Koenkk/zigbee-herdsman-converters#1661 |
Thanks! |
Koenkk/zigbee2mqtt#4240