Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TuYa Clusters for TS0505A #237

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Add TuYa Clusters for TS0505A #237

merged 4 commits into from
Oct 15, 2020

Conversation

MSchutt
Copy link
Contributor

@MSchutt MSchutt commented Oct 13, 2020

@MSchutt
Copy link
Contributor Author

MSchutt commented Oct 13, 2020

Please see Koenkk/zigbee-herdsman-converters#1661

@@ -2087,6 +2089,15 @@ const Cluster: {
{name: 'transtime', type: DataType.uint8},
],
},
moveToHueAndSaturationBrightness: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the ZCL: https://github.com/Koenkk/zigbee-herdsman/blob/master/docs/Zigbee%20Cluster%20Library%20Specification%20v7.pdf and command 6 is the moveToHueAndSaturation and does not provide a brigthness:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I know, but unfortunately my TuYa LEDs don't seem follow the standard for whatever reason. Please see attached an image of a packet captured via Wireshark.
The payload contains FF which is the brightness in the end.

wireshark

Hue: 0x55 = 85
Saturation: 0xFE = 254
Transition time: 0x0000 = 0
Brightness: 0xFF = 255

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case change moveToHueAndSaturationBrightness to tuyaMoveToHueAndSaturationBrightness

@Koenkk
Copy link
Owner

Koenkk commented Oct 15, 2020

Note to self: after this merge Koenkk/zigbee-herdsman-converters#1661

@Koenkk
Copy link
Owner

Koenkk commented Oct 15, 2020

Thanks!

@Koenkk Koenkk merged commit 8390ff3 into Koenkk:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants