fix!: Fix always use number for reportableChange
#1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
changed the title
int40, uint48 and uint40 parsingnumber for reportableChange
Koenkk
changed the title
number for reportableChangenumber for reportableChange
Nerivec
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Well, that fixes a leftover TODO I had marked when we moved/revamped the spec 👍
Probably should do the BigInt too (in buffalo.ts directly), if only to standardize the various parsers (currently inconsistent, as marked by the other TODO in buffaloZcl.ts). The n-append notation (123n) makes it easy enough to keep mostly plain numbers in the code (instead of BigInt(123)).
Note if ever needed: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#use_within_json
|
@Nerivec Done! |
Koenkk
added a commit
to Koenkk/zigbee-herdsman-converters
that referenced
this pull request
Sep 16, 2024
|
Made for a very nice cleanup in ZHC! |
Nerivec
reviewed
Sep 16, 2024
Nerivec
reviewed
Sep 16, 2024
Nerivec
reviewed
Sep 16, 2024
Koenkk
added a commit
to Koenkk/zigbee-herdsman-converters
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reportableChangecan be anumberor[number, number](to support larger ints). However sinceint40,uint48anduint40easily fit in a NodeNumber.MAX_SAFE_INTEGERthere is no need to use[number, number].(u)int56 and (u)int64 could be supported through a
BigInt, but in practice this will never be used.This fixes Koenkk/zigbee2mqtt#23711
TODO:
reportableChangechange zigbee-herdsman-converters#7996)