-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Rework OTA (add downgrade capability) #8273
Conversation
On phone so can't really see what is going on, but is it HTTP calls that are making the build / tests take a while? |
All downloads are mocked to use local files (see |
Done! PR LGTM! |
Note for your todo list, after dropping node 18, we can drop Also, ZH |
Supported will be dropped once it goes EOL! Thanks! |
* feat!: Rework OTA (add downgrade capability) * Remove unused deps * Cleanup * Fix (strict) --------- Co-authored-by: Koen Kanters <[email protected]>
Features:
Improvements:
Changes:
NODE_EXTRA_CA_CERTS
(likeHTTPS_PROXY
). Marked as breaking because technically, it is, just not sure how many users actually use this for local overrides...Dev:
ota.ts
ota
property in converter is now used to either just enable OTA for a device (ota: true
), or to pass specific extra metadata required for proper detection (ota: {hardwareVersionMax: 6}
)modelId
,manufacturerName
,hardwareVersionMin
,hardwareVersionMax
can be used to override match fromdevice
as neededRemovable dependencies (@Koenkk I'll let you deal with this):
fetch
built-infetch
supports using theHTTPS_PROXY
env directly (can't currently test it to confirm)@Koenkk
run test
from pre-commit is now making this a rather long process, OTA tests are nasty on length (jest just doesn't seem to handle the shear amount of calls well, probably because of all the tracking)...CC: @jamesonuk
TODO:
Fix #8131
Fix #8251
Fix Koenkk/zigbee2mqtt#24464
Probably more... (misbehaving previous URLs likely caused quite a few issues that will hopefully disappear...)