Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power metering support for SP600 not working for newly paired devices #848

Closed
davet2001 opened this issue Dec 27, 2019 · 5 comments
Closed

Comments

@davet2001
Copy link
Contributor

Power metering not working for SP600 devices if I re-pair them, see issue Koenkk/zigbee2mqtt#2352.

I have a fix for this and will submit a PR.

davet2001 added a commit to davet2001/zigbee-herdsman-converters that referenced this issue Dec 27, 2019
@davet2001
Copy link
Contributor Author

PR created:
#849

Koenkk added a commit that referenced this issue Dec 27, 2019
* SP600 fix power metering #848

* Update devices.js

Co-authored-by: Koen Kanters <[email protected]>
@Koenkk
Copy link
Owner

Koenkk commented Dec 27, 2019

Merged, thanks!

@Koenkk Koenkk closed this as completed Dec 27, 2019
@pedrolamas
Copy link
Contributor

@Koenkk Since this got merged, my SP600 is now reporting the power 10x higher than it should, so I think this fixed the other issue for which we added the specific converter!

I'm going to replace the fz.SP600_power with fz.generic_power and see if that fixes it.

@pedrolamas
Copy link
Contributor

Confirmed: changing to fz.generic_power now shows with correct power (so it now uses the multiplier)!!

I'll be opening a PR in a few minutes with this single change!

@pedrolamas
Copy link
Contributor

PR #898 created to fix the new problem.

xmow49 pushed a commit to xmow49/zigbee-herdsman-converters that referenced this issue Jun 14, 2024
)

* feat: add tests against mixed manufacturerCode attribute read/write/configureReporting

* feat: add tests for custom manufacturerCode read/write

* feat: endpoint.read/write/configureEndpoint should use definition manufacturerCode if available

* fix: move duplicate code to private function

* Update controller.test.ts

* Update controller.test.ts

* fix

* fix: rename ensureManufacturerCodeIsUnique to ensureManufacturerCodeIsUniqueAndGet

---------

Co-authored-by: Koen Kanters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants