Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build error while adding ios() target #16

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

maltsev-gorskij
Copy link
Contributor

PR for issue #6

  • Updated build.gradle.kts
  • Moved failing tests to jvm main, because it causes compilation errors if some files present in commonTest sourceSet. Dont know yet how to fix this concrete problem when tests are in commonTest folder
  • Removed deprecated parameters from gradle.properties

With this fixes i'v been able to build all library artifacts, published them to maven-local repo and tested koalaplot sample readme example with compose multiplatform on android and ios simulators both.

image

- Moved failing tests to jvm main, because its some problems is some files present in commonTest sourceSet
- Removed deprecated parameters from gradle.properties
Copy link
Member

@gsteckman gsteckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsteckman gsteckman merged commit aff364c into KoalaPlot:main Jun 17, 2023
@maltsev-gorskij maltsev-gorskij deleted the fix_ios_build_issues branch June 18, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants