Transfer the logic of enabling/disabling pan and zoom to the gesture handler #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asynchaizer
force-pushed
the
feature/refactor_pan_and_zoom_logic
branch
from
4ac6b8b to
3a52815
Compare
gsteckman
requested changes
Feb 2, 2025
| event.consumeChangedPositions() | ||
| if (zoomAllowed) { | ||
| val centroid = event.calculateCentroid(useCurrent = false) | ||
| onZoomChange(size, centroid, ZoomFactor(zoomChange, zoomChange)) |
There was a problem hiding this comment.
Can zoomFactor(zoomChange, zoomChange) be replaced with the val zoom created above?
There was a problem hiding this comment.
This section will be changed soon, as a panning animation for iOS/Android will be added.
(Actually, the animation implementation is already ready, but unfortunately I can't do cascading PR here, so I'm waiting for the current PR to be accepted)
| /** | ||
| * Whether the pan gesture on the X-axis should be consumed (handled). Has no effect for `js` and `wasmJs` | ||
| * If `true`, the pan gesture will be consumed and will not propagate further | ||
| * However, the gesture will still be processed but `PointerInputChange#consume` will not be called, |
There was a problem hiding this comment.
It looks like from the code, that change.consume() IS being called when this value is true.
There was a problem hiding this comment.
Oops, you're absolutely right, thanks! :)
asynchaizer
force-pushed
the
feature/refactor_pan_and_zoom_logic
branch
from
3a52815 to
5ed060a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of these changes:
from the parent container