[issues-107] apply StartAnimationUseCase in bar-chart (GroupedVerticalBarPlot.kt) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlliZi
changed the title
|
Hi @OlliZi, thanks for the additional contribution. The changes for the bar plot look good. I'd like to keep all "Demo" type of applications in the koalaplot-samples repository. Please either modify one of the existing bar plots there to demonstrate the use of the StartAnimationUseCase, or create a new example in that repository. |
|
@gsteckman My suggestion is to revert all demo code and only integrate the API change. Ok? |
|
Yes, that will work. |
|
Done. Demo code is reverted. |
OlliZi
commented
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#107
Apply
StartAnimationUseCasein bar-chart.