-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Node 16 #46
base: main
Are you sure you want to change the base?
Conversation
Agreed, can we get this merged? I also see the same message. |
@KnicKnic: Thanks for this project, and also for keeping potential bad actors out of GitHub workflows! ❤️ IMHO, first-time contributors with a long-term existing account are less likely to (ab)use random public workflows, though. If possible, please consider changing the "Require approval for first-time contributors" repo setting to "Require approval for first-time contributors who are new to GitHub" (emphasis mine). @carlkid1499: until it gets merged here, the fix is available from my fork. It's possible to use In fact, I'm already using it that way in one of my projects, and will revert back to this action when this issue is resolved. |
@ferki Thanks!, I went ahead and made my detached fork - https://github.com/carlkidcrypto/os-specific-runner, https://github.com/marketplace/actions/os-specific-runner. |
@carlkidcrypto: thanks for the fork! Given that by now even node16 runners are getting deprecated in favor of node20, and your fork already seems to support that, I'll probably migrate my relevant workflows to use your version instead. Also thanks for your offer to add me as a maintainer over there! I don't have experience maintaining NodeJS solutions, and currently I'm not looking increase my existing maintainer responsibilities. However I'd be glad to send you patches in the future whenever I can meaningfully contribute, and I'm open to come back to this topic if that gets regular. |
I noticed some of my workflows keep displaying the following warning annotation:
The above link describes the issue in more detail, and includes some pointers about what to do about it. The fix seemed like a trivial version bump, and I decided to send this quick PR about it.
Please review and merge, or let me know how to improve it!