-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: Add cifuzz #186
base: master
Are you sure you want to change the base?
fuzz: Add cifuzz #186
Conversation
4a4d78b
to
3804a3d
Compare
1ef57e2
to
4c6a423
Compare
Why is it a draft? |
4c6a423
to
31eb0eb
Compare
I wanted to test something. Will mark it as ready for review. |
Am I still going to receive emails if there are issues on the fuzz thingy after this? Also... I guess the idea is not to run this in every PR? 👀 |
For
Idea is to run this on every PR as that helps in catching regression, but this can be restricted to particular branch like Do you want to limit the run to releases or a specific branch? |
31eb0eb
to
a5fb39a
Compare
It can be on schedule or on main, but on every PR will be too much for me. Would you mind changing it? 🙏 |
b763aeb
to
420a664
Compare
I have scheduled it to run on 12:00pm every monday. |
420a664
to
4b696b2
Compare
4b696b2
to
4fc09b3
Compare
e908a58
to
b546fc6
Compare
I have updated the workflow to run only for the 'release/**' branch, as the scheduled run doesn’t make sense here since OSS-Fuzz already runs it daily. |
@@ -1241,7 +1241,7 @@ def data_callback(name: CallbackName, end_i: int, remaining: bool = False) -> No | |||
elif state == MultipartState.HEADER_VALUE_ALMOST_DONE: | |||
# The last character should be a LF. If not, it's an error. | |||
if c != LF: | |||
msg = "Did not find LF character at end of header " "(found %r)" % (c,) | |||
msg = "Did not find LF character at end of header (found %r)" % (c,) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint via uv in script/check was failing ci, so had to apply this format for it work.
This PR adds [cifuzz](https://google.github.io/oss-fuzz/getting-started/continuous-integration/) action workflow which is a service provided by oss-fuzz where this project already runs, this helps in catching shallow bugs, regression or build breakage by running fuzzers on PR for ~5 minutes (excluding the build time) on 'release/**' branch.
b546fc6
to
b478bf7
Compare
This PR adds cifuzz action workflow which is a service provided by oss-fuzz where this project already runs, this helps in catching shallow bugs, regression or build breakage by running fuzzers on PR for ~5 minutes (excluding the build time) on 'release/**' branch..