Allow digits and valid token chars in headers #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #133 |
Kludex
approved these changes
Apr 18, 2024
| def lower_char(c: int) -> int: | ||
| return c | 0x20 | ||
| # Mask for ASCII characters that can be http tokens. | ||
| # Per RFC7230 - 3.2.6, this is all alpha-numeric characters |
There was a problem hiding this comment.
Can you add the link on the comment as well, please?
There was a problem hiding this comment.
Sure. I added a commit with the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part header parsing has been extended to allow additional non-alpha characters that are allowed by the http spec.
In general http header field names can contain a variety of non-alpha characters, yet the present code only allows for a hyphen in addition to alphabetic characters. For multipart/form-data this may not be a a problem since additional headers are discouraged. For other multipart types, such as
relatedandmixed, it may be an issue.Since there was a test explicitly checking for failure with numbers in the header name, this seems to been an active choice. I altered this test to replace the numbers with characters forbidden by the spec.
The
lower_charfunction was removed because it was no longer used.