Check if Message.get_params return 3-tuple instead of str on `p…

…arse_options_header` (#79) * Fixing issue #78 * Added test for parse_options_header * Added a comment clarifying a condition in parse_options_header * Fixed a typo --------- Co-authored-by: lorenpike <[email protected]>
Kludex · Feb 9, 2024 · 26d664f · 26d664f
1 parent cb0b7cf
commit 26d664f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/multipart/multipart.py b/multipart/multipart.py
@@ -99,6 +99,11 @@ def parse_options_header(value: Union[str, bytes]) -> Tuple[bytes, Dict[bytes, b
     options = {}
     for param in params:
         key, value = param
+        # If the value returned from get_params() is a 3-tuple, the last
+        # element corresponds to the value.
+        # See: https://docs.python.org/3/library/email.compat32-message.html
+        if isinstance(value, tuple):
+            value = value[-1]
         # If the value is a filename, we need to fix a bug on IE6 that sends
         # the full file path instead of the filename.
         if key == 'filename':

diff --git a/tests/test_multipart.py b/tests/test_multipart.py
@@ -276,6 +276,11 @@ def test_redos_attack_header(self):
         # If vulnerable, this test wouldn't finish, the line above would hang
         self.assertIn(b'"\\', p[b'!'])
 
+    def test_handles_rfc_2231(self):
+        t, p = parse_options_header(b'text/plain; param*=us-ascii\'en-us\'encoded%20message')
+
+        self.assertEqual(p[b'param'], b'encoded message')
+
 
 class TestBaseParser(unittest.TestCase):
     def setUp(self):