Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports retrieving the name of the currently loaded skew correction … #6821

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GofranChang
Copy link

@GofranChang GofranChang commented Feb 13, 2025

Added a command to retrieve the name of the current tilt correction configuration.

In some cases (such as enabling filament cutter or nozzle wipe), activating tilt correction may cause the tool head to exceed its range of motion. By retrieving the current tilt correction name, it is possible to get the tilt configuration name before execution, unload tilt correction, execute the command (cut filament or wipe nozzle), and then reload tilt correction using the obtained name.

Signed-off-by: Zhang Gaofan [email protected]

@JamesH1978
Copy link
Collaborator

Thankyou for submitting a PR, please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks
James

@Arksine
Copy link
Collaborator

Arksine commented Feb 14, 2025

It would probably be better to report the current profile name in a get_status() method rather than print it via gcode command. Then you can use templates in your custom macros to look up the name and do whatever you need with it.

@GofranChang
Copy link
Author

Thankyou for submitting a PR, please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

Thank you for the reminder. I have added my signature.

@GofranChang
Copy link
Author

It would probably be better to report the current profile name in a get_status() method rather than print it via gcode command. Then you can use templates in your custom macros to look up the name and do whatever you need with it.

Thank you for your suggestion. I have updated the code following your method, and it is now working well.

@KevinOConnor
Copy link
Collaborator

Thanks. Any changes to exported status information should also have a corresponding change to docs/Status_Reference.md . Also, for what it is worth, probably best to fully spell out the names of the status variables that are being exported (eg, something like "current_profile_name").

Cheers,
-Kevin

@GofranChang
Copy link
Author

Thanks. Any changes to exported status information should also have a corresponding change to docs/Status_Reference.md . Also, for what it is worth, probably best to fully spell out the names of the status variables that are being exported (eg, something like "current_profile_name").

Cheers, -Kevin

OK, it's done (^○^)

@KevinOConnor
Copy link
Collaborator

Thanks. Seems fine to me. I'll give a few days to see if there are any further comments, but otherwise look to commit.

-Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants