-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slic3r_vars: Enable slic3r parameters to be read from gcode #4935
slic3r_vars: Enable slic3r parameters to be read from gcode #4935
Conversation
1d6c03c
to
1905726
Compare
Slic3r (and prusaslicer / SuperSlicer) can output all its parameters into the gcode file it creates. This allows these to be read within macros while printing: {printer.slic3r_vars.extruder_offset} == "0x0,20x0" for example. Signed-off-by: Tom Whitwell <[email protected]>
1905726
to
ee6e8f0
Compare
Signed-off-by: Tom Whitwell <[email protected]>
298e956
to
2c60e71
Compare
This is currently done on Moonraker side (it parses the GCode to retrieve certain features, such as the startup hotend and bed temperatures). Having said that, I understand why you would want this on Klipper side for macros, but I don't think this is actually necessary for that purpose, as you can do this manually on any slicer just by adding parameters to your |
For sure, fully understand that it's possible to do in other ways, but I find the start gcode really difficult to read and keep up to date. You end up writing a load of supporting code in the macros, which just read these parameters into variables anyway - it's not even as if klipper automatically pulls certain settings in, you still have to do some kind of processing. Now I've started using my fork, my start gcode in the slicer is just My macros are mirrored here: https://github.com/whi-tw/klipper-macros, and my |
Thanks. It seems interesting, but as a high-level comment, I'm not really sure what this does or the benefit it provides to users. I'm going to mark this as needing a reviewer that can weigh in on the benefit. -Kevin |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Slic3r (and prusaslicer / SuperSlicer) can output all their parameters into the gcode file it creates.
This allows these to be read within macros while printing:
{printer.slic3r_vars.extruder_offset}
=="0x0,20x0"
for example.