Skip to content
This repository has been archived by the owner on Nov 29, 2020. It is now read-only.

webpack config changed for url and file loaders #263

Merged
merged 4 commits into from
Dec 2, 2017

Conversation

PrudhviRaj5
Copy link
Contributor

No description provided.

@PrudhviRaj5
Copy link
Contributor Author

Hi @KleoPetroff,
Are you planning to merge this or you want to keep this as a separate branch? I can add history fallback and redux next. Even if the Redux is added, people can still use React state management and it's always optional. Please tell me what I should do next?

@KleoPetroff
Copy link
Owner

I'm planning to merge it after I review it since it contains the file loader fix. It was better to create another PR just for the dependency updates, as I have some considerations about updating eslint, which may delay the merge.

You can go for the history fallback next. As for Redux, I don't plan to add it to master. You can create a separate branch for the implementation.

"eslint": "3.19.0",
"eslint-config-airbnb": "15.1.0",
"eslint-loader": "1.8.0",
"eslint": "4.12.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does 4.21.1 work with the eslint-loader? Have you tested it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I have tested everything (with webpack dev & prod) and have pushed the code. You can pull the branch and check it once if you like.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@KleoPetroff KleoPetroff merged commit 29a496d into KleoPetroff:master Dec 2, 2017
@KleoPetroff
Copy link
Owner

Thank you again for the wonderful work you did. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants