Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local remote switch #483

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Fix local remote switch #483

merged 3 commits into from
Aug 22, 2018

Conversation

scottwittenburg
Copy link
Contributor

No description provided.

@scottwittenburg scottwittenburg force-pushed the fix-local-remote-switch branch from ad2bcbd to 19122bf Compare August 22, 2018 20:51
@scottwittenburg
Copy link
Contributor Author

ping @jourdain

That first commit fixes the issue we saw last week switching back and forth between local and remote rendering.

Then I updated a couple of dependencies. Afterward, I ran through some of the npm scripts to make sure things still worked after the kw-web-suite update. I also ran the tests locally, as well copying the sources into visualizer to test that the prettier reformat didn't break anything. And then finally, I looked through those reformat changes, and didn't see anything that looked questionable.

…rendering

By relaxing this equality test, the string "317" will compare equal to the number 317 and
vice-versa, which is the desired effect in this case.
@scottwittenburg scottwittenburg force-pushed the fix-local-remote-switch branch from 19122bf to 030fb4f Compare August 22, 2018 21:17
@jourdain
Copy link
Collaborator

once green merge

@scottwittenburg scottwittenburg merged commit c7849d6 into master Aug 22, 2018
@scottwittenburg scottwittenburg deleted the fix-local-remote-switch branch August 22, 2018 21:39
@jourdain
Copy link
Collaborator

🎉 This PR is included in version 3.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants