Add foreign key constraints for all buildids

app/cdash/tests/case/CDash/MultipleSubprojectsEmailTest.php

@@ -35,7 +35,7 @@ class MultipleSubprojectsEmailTest extends CDashUseCaseTestCase
     private static $tz;
     private static $database;
 
-    private int $projectid = -1;
+    private static int $projectid = -1;
 
     /** @var  Database|PHPUnit_Framework_MockObject_MockObject $db */
     private $db;
@@ -69,6 +69,13 @@ public static function tearDownAfterClass() : void
         date_default_timezone_set(self::$tz);
         Database::setInstance(Database::class, self::$database);
 
+        DB::delete('DELETE FROM project WHERE id = ?', [self::$projectid]);
+
+        // Clean up all of the placeholder builds we created
+        for ($i = 0; $i < 10; $i++) {
+            DB::table('build')->where('name', '=', 'TestBuild' . $i)->delete();
+        }
+
         parent::tearDownAfterClass();
     }
 
@@ -103,16 +110,20 @@ public function setUp() : void
         $this->createApplication();
         config(['app.url' => 'http://open.cdash.org']);
 
-        $this->projectid = DB::table('project')->insertGetId([
-            'name' => 'TestProject1',
-        ]);
-    }
-
-    public function tearDown(): void
-    {
-        DB::delete('DELETE FROM project WHERE id = ?', [$this->projectid]);
-
-        parent::tearDown();
+        if (self::$projectid === -1) {
+            self::$projectid = DB::table('project')->insertGetId([
+                'name' => 'TestProject1',
+            ]);
+
+            // A hack to make sure builds exist and can be referenced so we don't violate our foreign key constraints
+            for ($i = 0; $i < 10; $i++) {
+                DB::table('build')->insertOrIgnore([
+                    'projectid' => self::$projectid,
+                    'name' => 'TestBuild' . $i,
+                    'uuid' => 'TestBuild' . $i,
+                ]);
+            }
+        }
     }
 
     /**
@@ -167,7 +178,7 @@ private function getNotifications(array $subscribers)
     public function testMultipleSubprojectsTestSubmission()
     {
         $this->useCase = UseCase::createBuilder($this, UseCase::TEST)
-            ->setProjectId($this->projectid)
+            ->setProjectId(self::$projectid)
             ->createSite([
                 'BuildName' => 'CTestTest-Linux-c++-Subprojects',
                 'BuildStamp' => '20160728-1932-Experimental',

app/cdash/tests/case/CDash/TestUseCaseTest.php

@@ -18,13 +18,28 @@ public function setUp(): void
             'name' => 'TestProject1',
         ]);
 
+        // A hack to make sure builds exist and can be referenced so we don't violate our foreign key constraints
+        for ($i = 0; $i < 10; $i++) {
+            DB::table('build')->insert([
+                'id' => $i,
+                'projectid' => $this->projectid,
+                'name' => 'TestBuild' . $i,
+                'uuid' => 'TestBuild' . $i,
+            ]);
+        }
+
         parent::setUp();
     }
 
     public function tearDown(): void
     {
         DB::delete('DELETE FROM project WHERE id = ?', [$this->projectid]);
 
+        // Clean up all of the placeholder builds we created
+        for ($i = 0; $i < 10; $i++) {
+            DB::table('build')->where('name', '=', 'TestBuild' . $i)->delete();
+        }
+
         parent::tearDown();
     }
 

app/cdash/tests/test_uniquediffs.php

@@ -3,6 +3,9 @@
 // After including cdash_test_case.php, subsequent require_once calls are
 // relative to the top of the CDash source tree
 //
+use CDash\Model\Build;
+use Illuminate\Support\Facades\DB;
+
 require_once dirname(__FILE__) . '/cdash_test_case.php';
 
 
@@ -19,27 +22,14 @@ public function __construct()
 
     public function testUniqueDiffs()
     {
-        // Find the highest buildid created so far and add one to it.
-        // This should give us a buildid that doesn't exist yet.
         $pdo = \CDash\Database::getInstance();
-        $stmt = $pdo->query('SELECT id FROM build ORDER BY id DESC LIMIT 1');
-        $row = $stmt->fetch();
-        $buildid = $row['id'];
-        $buildid++;
-
-        // Verify that this buildid does not exist yet.
-        $safe_build = false;
-        while (!$safe_build) {
-            $stmt = $pdo->prepare('SELECT id FROM build WHERE id=?');
-            $stmt->execute([$buildid]);
-            $row = $stmt->fetch();
-            if (!$row) {
-                $this->BuildId = $buildid;
-                $safe_build = true;
-            } else {
-                $buildid++;
-            }
-        }
+
+        $build = new Build();
+        $build->ProjectId = 1;
+        $build->Name = 'uniquediffs_test_build';
+        $this->assertTrue($build->AddBuild());
+        $this->BuildId = $build->Id;
+
 
         // Perform multiple INSERTs that violate the unique constraint
         // and verify that only one row is recorded.
@@ -92,6 +82,8 @@ public function testUniqueDiffs()
         $stmt->execute([$this->BuildId]);
         $stmt = $pdo->prepare('DELETE FROM testdiff WHERE buildid=?');
         $stmt->execute([$this->BuildId]);
+
+        DB::delete('DELETE FROM build WHERE id = ?', [$build->Id]);
     }
 
     public function testUniqueDiffsUpgrade()