Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM-Swift/Kitura#962 Fix SSLService crashes and refactor and add tests #166

Closed
wants to merge 6 commits into from

Conversation

na-gupta
Copy link
Contributor

Description

  • Add state guards for IncomingSocketHandler write() and close() functions
  • Make sure we don't close sockets while they're being used
  • Refactor tests to extend from KituraNetTest
  • Add state properties so test configuration can be changed in one place
  • Add test SSL self signed certificates for unit testing
  • Make most unit tests use SSLService as it surfaces race condition problems whereas Socket mostly ignores them

Motivation and Context

Kitura/Kitura#959
Kitura/Kitura#962

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@na-gupta na-gupta self-assigned this Jan 13, 2017
@na-gupta na-gupta requested a review from shmuelk January 13, 2017 17:33
@codecov-io
Copy link

codecov-io commented Jan 13, 2017

Current coverage is 83.65% (diff: 72.72%)

Merging #166 into master will increase coverage by 0.12%

@@             master       #166   diff @@
==========================================
  Files            27         27          
  Lines          2344       2362    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1958       1976    +18   
  Misses          386        386          
  Partials          0          0          

Powered by Codecov. Last update be6ef92...30487ac

@shmuelk
Copy link
Collaborator

shmuelk commented Jan 16, 2017

I want to see this broken up into three separate PRs:

  1. Refactor tests
  2. Add SSL tests
  3. Fix SSL crashes.

@na-gupta
Copy link
Contributor Author

Will refactor this into two PRs - one for the tests restructuring and another for the SSL fixes

@na-gupta na-gupta closed this Jan 17, 2017
@na-gupta na-gupta deleted the issue_962 branch January 18, 2017 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants