Remove forced unwrapped optional try(s) #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
suggested changes
Sep 20, 2018
| do { | ||
| try serverChannel.close().wait() | ||
| } catch let error { | ||
| Log.error("Error: \(error)") |
There was a problem hiding this comment.
Can we have a more detailed error, something like Failed to close the server channel. Error: \(error)
nethraravindran
force-pushed
the
remove-IUO-Try
branch
4 times, most recently
from
54233b7 to
f452a61
Compare
pushkarnk
suggested changes
Sep 24, 2018
| clientChannel.write(NIOAny(HTTPClientRequestPart.head(request)), promise: nil) | ||
| _ = clientChannel.write(NIOAny(HTTPClientRequestPart.end(nil))) | ||
| do { |
There was a problem hiding this comment.
We're already in a do block here. I guess you don't need this one.
nethraravindran
force-pushed
the
remove-IUO-Try
branch
from
f452a61 to
1537b6b
Compare
pushkarnk
approved these changes
Sep 24, 2018
nethraravindran
force-pushed
the
remove-IUO-Try
branch
from
1537b6b to
8e13a48
Compare
nethraravindran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motive is to remove forced unwrapped optional
trymethods and replace withdo-try-catchto avoid crash