Refactor - HTTPServer upgrade handler #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
reviewed
Sep 6, 2018
| @@ -68,6 +68,8 @@ public class HTTPServer : Server { | |||
| /// The event loop group on which the HTTP handler runs | |||
| let eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount) | |||
|
|
|||
| private var channelHandlerCtx: ChannelHandlerContext? | |||
There was a problem hiding this comment.
Considering SwiftNIO conventions, simply calling this ctx may make sense?
There was a problem hiding this comment.
Yes :) calling ctx looks good
pushkarnk
reviewed
Sep 6, 2018
|
@nethraravindran You may also want to run tests from the WebSocket NIO port locally, before we merge this. |
nethraravindran
force-pushed
the
refactor-httpServer
branch
from
d100d81 to
3be6f16
Compare
|
Few WebSocket tests failed with #86 |
|
@pushkarnk Thanks! I have run WebSocket tests and all the tests are successful with this change 97772c6 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code around
KituraWebSocketUpgraderto improve readability