Build against Swift 5 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
requested review from
ianpartridge and
pushkarnk
and removed request for
ianpartridge
|
@pushkarnk could you review (particularly the change for ClientRequest) as I believe this alters its behaviour (its previous behaviour may have been wrong, but I suspect we don't have a test for this) FYI the compilation warning that Swift 5 produces is this: /Kitura-NIO/Sources/KituraNet/ClientRequest.swift:478:25: warning: string interpolation produces a debug description for a function value; did you mean to make this explicit?
return "Basic \(data.base64EncodedString)"
^~~~~~~~~~~~~~~~~~~~~~~~
/home/djones6/swift5/PRs/Kitura-NIO/Sources/KituraNet/ClientRequest.swift:478:30: note: use 'String(describing:)' to silence this warning
return "Basic \(data.base64EncodedString)"
~~~~~^~~~~~~~~~~~~~~~~~~
String(describing: ) |
|
Right @djones6 .. that's a very awkward miss. There was no test and there were no compilation warnings prior to Swift 5. Thanks! |
pushkarnk
approved these changes
Dec 16, 2018
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds testing with a Swift 5 development snapshot. The snapshot is defined in Travis as
SWIFT_DEVELOPMENT_SNAPSHOTconsistently across the IBM-Swift repos, to enable us to automate updating the version.