Do not store the HTTPDummyServerDelegate object

Kitura-Net keeps the HTTP server running even if a delegate isn't provided. We use a HTTPDummyServerDelegate for this purpose. Before this code change, we stored the dummy delegate in the delegate property of HTTPServer. This may be confusing to a user who will rightly think that delegate is nil if it isn't explicitly set.
Kitura · Sep 24, 2018 · 0d91164 · 0d91164
1 parent c815224
commit 0d91164
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/Sources/KituraNet/HTTP/HTTPServer.swift b/Sources/KituraNet/HTTP/HTTPServer.swift
@@ -164,10 +164,6 @@ public class HTTPServer : Server {
             upgraders.append(upgrader)
         }
 
-        if self.delegate == nil {
-            self.delegate = HTTPDummyServerDelegate()
-        }
-
         let bootstrap = ServerBootstrap(group: eventLoopGroup)
             .serverChannelOption(ChannelOptions.backlog, value: BacklogOption.OptionType(self.maxPendingConnections))
             .serverChannelOption(ChannelOptions.socket(SocketOptionLevel(SOL_SOCKET), SO_REUSEADDR), value: 1)