Support Swift 5 #24
Merged
Support Swift 5 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2019 10:37
There was a problem hiding this comment.
Can you add Travis testing of $SWIFT_DEVELOPMENT_SNAPSHOT on Xcode 10.2 please?
https://github.com/IBM-Swift/LoggerAPI/blob/29fc1a0baec00a089166d14308908b6af3b3817b/.travis.yml shows what we're aiming for.
|
@ianpartridge The Xcode 10.2 testing is using the Judging by the LoggerAPI travis.yml I assume you mean you also want a test for Xcode 10.2 without an |
|
Yes that's right, so that we test with Swift 5. In the future $SWIFT_DEVELOPMENT_SNAPSHOT won't be Swift 5. |
ianpartridge
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Swift 5, and use official Docker images for CI.