-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ccmark to 0.28.3 #11
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
======================================
Coverage 4.31% 4.31%
======================================
Files 31 31
Lines 25038 25038
======================================
Hits 1080 1080
Misses 23958 23958
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you remove the libcmark.pc
and scanners.re
files as they appear to not be needed by our build process.
Sources/Ccmark/README.md
Outdated
cmake .. | ||
``` | ||
* open src | ||
* copy any .h or .pc files into Kitura-Markdown/sources/Ccmark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just .h files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks
Updated cmark to version 0.28.3 and added readme with instructions on how to update cmark in future.