Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ccmark to 0.28.3 #11

Merged
merged 4 commits into from
Feb 26, 2018
Merged

Update ccmark to 0.28.3 #11

merged 4 commits into from
Feb 26, 2018

Conversation

Andrew-Lees11
Copy link
Contributor

Updated cmark to version 0.28.3 and added readme with instructions on how to update cmark in future.

@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #11   +/-   ##
======================================
  Coverage    4.31%   4.31%           
======================================
  Files          31      31           
  Lines       25038   25038           
======================================
  Hits         1080    1080           
  Misses      23958   23958
Flag Coverage Δ
#Ccmark 4.18% <0%> (ø) ⬆️
#KituraMarkdown 4.31% <0%> (ø) ⬆️
Impacted Files Coverage Δ
Sources/Ccmark/cmark_version.h 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f6023...9029df7. Read the comment docs.

Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you remove the libcmark.pc and scanners.re files as they appear to not be needed by our build process.

cmake ..
```
* open src
* copy any .h or .pc files into Kitura-Markdown/sources/Ccmark
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just .h files

Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks

@djones6 djones6 merged commit c02d3f1 into master Feb 26, 2018
@djones6 djones6 deleted the updateCcmark branch February 26, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants