Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Swift 4.2 #151

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Updated to Swift 4.2 #151

merged 3 commits into from
Oct 24, 2018

Conversation

ShihabMehboob
Copy link
Contributor

This PR aims to update to the Swift 4.2 release version.

Copy link
Collaborator

@billabt billabt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.travis.yml Outdated
@@ -16,18 +16,18 @@ matrix:
- os: linux
dist: trusty
sudo: required
env: SWIFT_SNAPSHOT=swift-4.2-DEVELOPMENT-SNAPSHOT-2018-06-23-a
env: SWIFT_SNAPSHOT=swift-4.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not needed. It'll default to the contents of .swift-version, in this case now to 4.2.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this the first time...

Copy link
Collaborator

@billabt billabt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@billabt
Copy link
Collaborator

billabt commented Oct 24, 2018

Will merge as soon as we've got a clean CI.

@billabt billabt merged commit 45c773c into master Oct 24, 2018
@ianpartridge ianpartridge deleted the swift42 branch October 24, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants