Update to Swift 5.1, fix crash on Linux #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI configuration to use the Swift 5.1 release toolchain.
While testing, I noticed an intermittent failure in
test_makeKeyPair()
that results in an error being thrown on macOS, and a hard crash on Linux (force-unwrapping nil):macOS:
Linux:
I've included a fix here for the force-unwrap:
d2i_PUBKEY_bio
andd2i_PrivateKey_bio
can fail (returning null) if the BIO does not contain a valid RSA key, but we were not handling that case. The test still fails intermittently, but with an error now:I tracked down the reason for the intermittent failure in #52 - an unsafe assumption that leads us - occasionally - to incorrectly drop the first 26 bytes of the key data. I added a test for this situation in a35c877 but I do not yet understand what the appropriate fix is, so this test is currently failing.