Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings UI page #171

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Add settings UI page #171

merged 11 commits into from
Jul 13, 2023

Conversation

franknoirot
Copy link
Collaborator

@franknoirot franknoirot commented Jul 13, 2023

Resolves tauri-apps/tauri#160. Does the following:

  • Adds a new AppHeader component
  • Adds react-router for navigation
  • Adds a new /settings route accessible through the Settings button in the AppHeader
  • Adds Tauri-only UI to either manually enter a new default directory or use the file picker to select one
  • Adds UI to edit a new "default project name" setting that does nothing at the moment.
  • Adds react-hot-toast to give a success message on save, and support future notification UI.

Demo

Screenshare.-.2023-07-12.8_43_37.PM.mp4

@franknoirot franknoirot added the enhancement New feature or request label Jul 13, 2023
@franknoirot franknoirot requested a review from Irev-Dev July 13, 2023 00:47
@franknoirot franknoirot self-assigned this Jul 13, 2023
@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
untitled-lang ✅ Ready (Inspect) Visit Preview Jul 13, 2023 4:36am

Copy link
Collaborator

@Irev-Dev Irev-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
It would be good to get tests passing again before we merge.

src/components/ActionButton.tsx Outdated Show resolved Hide resolved
because we use RouterProvider
@franknoirot franknoirot merged commit 59fa51d into main Jul 13, 2023
@franknoirot franknoirot deleted the settings-ui branch July 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants