Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 UI for settings (default dir being one of them) #160

Closed
Tracked by #149
Irev-Dev opened this issue Jul 11, 2023 · 4 comments
Closed
Tracked by #149

💅 UI for settings (default dir being one of them) #160

Irev-Dev opened this issue Jul 11, 2023 · 4 comments
Assignees

Comments

@Irev-Dev
Copy link
Collaborator

Irev-Dev commented Jul 11, 2023

in src/hooks/useTauriBoot.ts there's some logic around the default directory already that got merged early due to stuff happening in parallel between the engine getting hooked up to the app and the tauri work I was doing.

We should have a sane default directory, but allow users to specify where that is.
But we also need to a place to put odd bits of user preferences and settings, this is a good reference for this that basically says local storage is probably perfect for what we need from it.

We had talked about having the settings like vscode where it's all JSON and we add some nice UI for that JSON. I now think that's a polish item that we should skip for now, let's just have half-decent UI and we can bolt the rest on later.

With all that said, the task is to

  • add somewhere in the app for persistent settings to go.
  • Persist them with local storage (I think that's the way to go, this filter tells zustand which keys to persist)
  • The UI should have default dir as the first setting.

Steps for booting up tauri should be

yarn install
yarn build:wasm  # or yarn build:wasm:ci if not on mac
yarn tauri dev
@Irev-Dev
Copy link
Collaborator Author

@franknoirot I assigned you three related issues, start here.

(Also I plan on having tauri-apps/tauri#162 closed by the time you're up, if not sorry 😬 )

@franknoirot
Copy link
Collaborator

Working on mocking this up here

@franknoirot
Copy link
Collaborator

I think we need a top bar and a little user menu to get underway here. Then the user can see they are logged in, can log out, and we have a place to put the link to the settings page. Here is a prototype in Figma showing the flow.

Here is a view with the user menu open:
User Menu Opened

Here is a view of the user settings page:
Settings Opened

Do these seem okay to move on? I'll get reacquainted with the codebase in the meantime.

@franknoirot
Copy link
Collaborator

Heads up there's active work being done to support the New Folder button on MacOS for dialogs created with Tauri: tauri-apps/plugins-workspace#949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants