Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trace Control] Add back culling rendering to speed up rendering large graphs #784

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

yuehuang010
Copy link
Contributor

@yuehuang010 yuehuang010 commented Jun 11, 2024

In Trace Control, reduce rendering to current viewport

  • Significantly improve loading time by not rendering parts of the graph outside of the current view.
  • This reduces load times from ~1-2 mins to ~5 seconds on 500mb binlog.
  • Swap HeatGraph from Canvas to FastCanvas to also benefit from the reduce rendering.
    • Removed the perf workaround that was previously added.
    • Set the resolution to 100ms per bar.

@yuehuang010 yuehuang010 changed the title Add back culling rendering, speed up rendering when loading really large graphs [Trace Control] Add back culling rendering, speed up rendering when loading really large graphs Jun 11, 2024
@yuehuang010 yuehuang010 changed the title [Trace Control] Add back culling rendering, speed up rendering when loading really large graphs [Trace Control] Add back culling rendering to speed up rendering really large graphs Jun 11, 2024
@yuehuang010 yuehuang010 changed the title [Trace Control] Add back culling rendering to speed up rendering really large graphs [Trace Control] Add back culling rendering to speed up rendering large graphs Jun 11, 2024
@KirillOsenkov KirillOsenkov merged commit 6a19cd7 into KirillOsenkov:main Jun 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants