Add native Arm64 support #763
Conversation
|
|
src/StructuredLogViewer/app.manifest
Outdated
| @@ -0,0 +1,30 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"> | |||
| <assemblyIdentity version="1.0.0.0" name="MyApplication.app"/> | |||
There was a problem hiding this comment.
what should the identity be? Perhaps MSBuildStructuredLogViewer.app?
There was a problem hiding this comment.
if this is intended to be the assembly name, then perhaps StructuredLogViewer.app?
There was a problem hiding this comment.
The article says:
Uniquely names the application or assembly. Use the following format for the name:
Organization.Division.Name. For exampleMicrosoft.Windows.mysampleApp. Required.
Maybe we can do something like MSBuildStructuredLog.StructuredLogViewer/MSBuildStructuredLog.TaskRunner? These names aren't used for anything, we don't use the unmanaged assembly binding, it's just for tidiness
src/TaskRunner/app.manifest
Outdated
| @@ -0,0 +1,17 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"> | |||
| <assemblyIdentity version="1.0.0.0" name="MyApplication.app"/> | |||
|
Very cool! Does the app.manifest file need to be shipped with the app or does it get embedded directly inside the executable? Let's clarify the assemblyIdentity and then we're good to go! |
|
The app manifest appears to be embedded into the exe, so, no complications there hopefully |
|
Thank you! |
The .NET Framework versions of
StructuredLogViewerandTaskRunnerwill run natively on Arm64. This is using the newsupportedArchitectureselement in the application manifest.