Skip to content

Commit

Permalink
Revert breaking change in the reader for ProjectEvaluationFinished
Browse files Browse the repository at this point in the history
I don't understand this, so we'll need to patch it later.

For now revert it to what it was to read existing binlogs properly.
  • Loading branch information
KirillOsenkov committed Jan 10, 2024
1 parent 7901b7f commit d72b8bf
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/StructuredLogger/BinaryLogger/BuildEventArgsReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -723,12 +723,11 @@ private BuildEventArgs ReadProjectEvaluationFinishedEventArgs()

if (_fileFormatVersion >= 12)
{
if (_fileFormatVersion < BinaryLogger.ForwardCompatibilityMinimalVersion)
IEnumerable globalProperties = null;
if (ReadBoolean())
{
// Throw away, but need to advance past it
ReadBoolean();
globalProperties = ReadStringDictionary();
}
IEnumerable? globalProperties = ReadStringDictionary();

var propertyList = ReadPropertyList();
var itemList = ReadProjectItems();
Expand Down

0 comments on commit d72b8bf

Please sign in to comment.