Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Cliquet 3 (fixes #345, fixes #fixes #369, fixes #421, fixes #424, fixes #433, fixes #434, fixes #461) #479

Merged
merged 3 commits into from
Mar 7, 2016

Conversation

leplatrem
Copy link
Contributor

No description provided.

@leplatrem leplatrem changed the title Upgrade to Cliquet 3 (fixes #345, fixes #fixes #369, fixes #421, fixes #424, fixes #433, fixes #434) Upgrade to Cliquet 3 (fixes #345, fixes #fixes #369, fixes #421, fixes #424, fixes #433, fixes #434, fixes $461) Feb 29, 2016
@leplatrem leplatrem changed the title Upgrade to Cliquet 3 (fixes #345, fixes #fixes #369, fixes #421, fixes #424, fixes #433, fixes #434, fixes $461) Upgrade to Cliquet 3 (fixes #345, fixes #fixes #369, fixes #421, fixes #424, fixes #433, fixes #434, fixes #461) Feb 29, 2016
does not exist (#656)
- Partial responses can now be specified for nested objects (#445)
For example, ``/records?_fields=address.street``.
- List responses are now sorted by to last_modified descending by default (#434,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"by to"

@almet
Copy link
Member

almet commented Mar 1, 2016

That's a bunch of cool changes! Great.

@leplatrem
Copy link
Contributor Author

I can't reproduce locally the timestamp constraint errors of the loadtest_simulation.

They seem to always occur on current bucket and collection creation, on the timestamps_pkey constraint.
This could be related to this code:
https://github.com/mozilla-services/cliquet/blob/3.0.0/cliquet/storage/postgresql/schema.sql#L154-L158
which inserts a timestamp when could not find one. Unicity can be violated with concurrent transactions.

PS: good news, load tests have approximately 15% more RPS from cliquet 2.15 to cliquet 3

BackendError: IntegrityError: (psycopg2.IntegrityError) duplicate key value violates unique constraint "timestamps_pkey"

DETAIL:  Key (parent_id, collection_id)=(/buckets/blocklist, collection) already exists.

CONTEXT:  SQL statement "INSERT INTO timestamps (parent_id, collection_id, last_modified)

      VALUES (uid, resource, ts)"

PL/pgSQL function collection_timestamp(character varying,character varying) line 14 at SQL statement

 [SQL: '\n        SELECT as_epoch(collection_timestamp(%(parent_id)s, %(collection_id)s))\n            AS last_modified;\n        '] [parameters: {'parent_id': u'/buckets/blocklist', 'collection_id': 'collection'}]; uid=None; errno=None; agent=python-requests/2.9.1; authn_type=None

CRITICAL:venusian:"PUT   /v1/buckets/blocklist/collections/addons" ? (? ms) (psycopg2.IntegrityError) duplicate key value violates unique constraint "timestamps_pkey"

DETAIL:  Key (parent_id, collection_id)=(/buckets/blocklist, collection) already exists.

@leplatrem leplatrem force-pushed the upgrade-cliquet-3 branch from eecada6 to af78626 Compare March 4, 2016 08:10
@leplatrem
Copy link
Contributor Author

Would you be willing to merge it like this and go forward ?

@Natim
Copy link
Member

Natim commented Mar 4, 2016

Yes I would :)

@almet
Copy link
Member

almet commented Mar 5, 2016

Yes, I think we should merge this (but it needs to be rebased first)

@leplatrem leplatrem force-pushed the upgrade-cliquet-3 branch from 5c6e9ca to 7910d12 Compare March 7, 2016 08:40
leplatrem added a commit that referenced this pull request Mar 7, 2016
Upgrade to Cliquet 3 (fixes #345, fixes #fixes #369, fixes #421, fixes #424, fixes #433, fixes #434, fixes #461)
@leplatrem leplatrem merged commit c5e8f42 into master Mar 7, 2016
@leplatrem leplatrem deleted the upgrade-cliquet-3 branch March 7, 2016 08:55
@leplatrem leplatrem restored the upgrade-cliquet-3 branch March 8, 2016 09:45
@leplatrem leplatrem deleted the upgrade-cliquet-3 branch March 8, 2016 09:45
@leplatrem leplatrem modified the milestone: 2.0 Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants