refactor Timeline class to pydantic model #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
approved these changes
Aug 10, 2020
This was
linked to
issues
Aug 10, 2020
This was
unlinked from
issues
Aug 10, 2020
|
@tanwinn is there anything else you want to do here before I merge? |
Co-authored-by: Sourcery AI <>
Travis Test failureImportError while loading conftest '/home/travis/build/Kilo59/coronavirus-tracker-api/tests/conftest.py'.
tests/conftest.py:13: in <module>
from app.main import APP
app/main.py:17: in <module>
from .data import data_source
app/data/__init__.py:3: in <module>
from ..services.location.jhu import JhuLocationService
app/services/location/jhu.py:13: in <module>
from ...models import Coordinates, Timeline
E ImportError: cannot import name 'Coordinates' from 'app.models' (/home/travis/build/Kilo59/coronavirus-tracker-api/app/models.py) |
|
Hm.. this fail is new. Did you merge something after my PR? |
update isort usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.