Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed "Different objects than vehicles aren't recycleable" #612

Merged
merged 2 commits into from
May 14, 2019
Merged

fixed "Different objects than vehicles aren't recycleable" #612

merged 2 commits into from
May 14, 2019

Conversation

Dubjunk
Copy link
Contributor

@Dubjunk Dubjunk commented May 13, 2019 •
edited
Loading

Q A
Bug fix? yes
New feature? no
Needs wipe? no
Fixed issues #603-5

Description:

This PR fixes Different objects than vehicles aren't recycleable .
Also the resupply menu now filters the vehicles when ACE resupply is enabled, so that only ACE fuel/rearm vehicles will be displayed.

Content:

  • Bug fix for 603-5
  • Additional resupply filter for ace fuel/rearm vehicles

Successfully tested on:

  • Local MP
  • Dedicated MP

Compatibility checked with:

  • ACE

@Dubjunk Dubjunk added this to the Sprint 13 milestone May 13, 2019
@Dubjunk Dubjunk requested review from Wyqer and veteran29 May 13, 2019 20:00
@Dubjunk Dubjunk self-assigned this May 13, 2019
Wyqer
Wyqer approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in the scope of the bugfix. Great you've handled it that fast.
Just a small suggestion concerning getting rid of the _name variable. Or maybe I've overlooked something concerning the decision to do it like that.

Missionframework/modules/23_logistic/fnc/fn_logistic_refreshTargets.sqf Show resolved Hide resolved
Missionframework/modules/23_logistic/fnc/fn_logistic_refreshTargets.sqf Outdated Show resolved Hide resolved
@Dubjunk Dubjunk merged commit bf66c3d into v0.97S13 May 14, 2019
@Dubjunk Dubjunk deleted the v0.97S13-603-5 branch May 14, 2019 20:31
@Wyqer Wyqer added done and removed review/QA labels May 16, 2019
@Wyqer Wyqer mentioned this pull request Jun 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

@veteran29 veteran29 veteran29 approved these changes

Assignees

@Dubjunk Dubjunk

Labels
None yet
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.
3 participants
@Dubjunk @Wyqer @veteran29