Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garrison module pt4 (Garrison dialog) #599

Merged
merged 22 commits into from
May 4, 2019
Merged

Garrison module pt4 (Garrison dialog) #599

merged 22 commits into from
May 4, 2019

Conversation

Wyqer
Copy link
Member

@Wyqer Wyqer commented May 1, 2019

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #587

Description:

Part 4 of the garrison module was about finishing the garrison dialog. It is now designed and hold functionalities to manage player side garrisons by adding AI groups/units which are near the sector and also ungarrison units from the garrison again.
Furthermore a permission setting was added to allow specific users access to the garrison management, if no admin is online.
The issue with old vehicles in enemy garrisons after switching the army presets was also adressed and fixed in this task.

Current look of the garrison dialog:
garrisonDialog

Content:

  • Finished garrison management dialog design
  • Ungarrison infantry/vehicles via dialog from garrisons
  • Add AI units/groups to a garrison via dialog
  • Fixed issue that garrison vehicles aren't reinitialized upon preset change
  • Permission for garrison dialog access

Successfully tested on:

  • Local MP
  • Dedicated MP

@Wyqer Wyqer added the review/QA label May 1, 2019
@Wyqer Wyqer added this to the Sprint 12 milestone May 1, 2019
@Wyqer Wyqer requested review from veteran29 and Dubjunk May 1, 2019 21:07
@Wyqer
Copy link
Member Author

Wyqer commented May 1, 2019

@KillahPotatoes/kplib-testers
It would be great if you start some testing on the mentioned functionality and give it a test in dedicated environment.

Copy link
Contributor

@Dubjunk Dubjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work on the dialog 👍

Missionframework/modules/16_garrison/ui/defines.hpp Outdated Show resolved Hide resolved
@Wyqer Wyqer merged commit 5106778 into v0.97S12 May 4, 2019
@Wyqer Wyqer added done and removed review/QA labels May 4, 2019
@Wyqer Wyqer deleted the v0.97S12-587 branch May 4, 2019 17:16
@Wyqer Wyqer mentioned this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants