-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garrison module pt4 (Garrison dialog) #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@KillahPotatoes/kplib-testers |
Dubjunk
approved these changes
May 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work on the dialog 👍
veteran29
requested changes
May 3, 2019
Missionframework/modules/16_garrison/fnc/fn_garrison_preInit.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/16_garrison/fnc/fn_garrison_preInit.sqf
Outdated
Show resolved
Hide resolved
veteran29
approved these changes
May 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Part 4 of the garrison module was about finishing the garrison dialog. It is now designed and hold functionalities to manage player side garrisons by adding AI groups/units which are near the sector and also ungarrison units from the garrison again.
Furthermore a permission setting was added to allow specific users access to the garrison management, if no admin is online.
The issue with old vehicles in enemy garrisons after switching the army presets was also adressed and fixed in this task.
Current look of the garrison dialog:
Content:
Successfully tested on: