Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission module additions #577

Merged
merged 10 commits into from
Mar 17, 2019
Merged

Permission module additions #577

merged 10 commits into from
Mar 17, 2019

Conversation

Dubjunk
Copy link
Contributor

@Dubjunk Dubjunk commented Mar 16, 2019

Q A
Bug fix? no
New feature? no
Needs wipe? no
Fixed issues #571

Description:

This PR provides some smaller additions for the permission module.
A fresh save requires now an admin login to setup the basic permissions like commander / subcommander access.
Additionally the Build Menu and Logistic Station access can now be handled via permission dialog.

Content:

  • Build permission
  • Logistic Station permission
  • Commander & Sub-Commander permission
  • Additions to the registerPlayer function
  • CBA settings for permission dialog access

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • ACE

@Dubjunk Dubjunk added this to the Sprint 11 milestone Mar 16, 2019
@Dubjunk Dubjunk requested review from Wyqer and veteran29 March 16, 2019 21:17
Wyqer
Wyqer approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine so far.
The two suggestions aren't critical, so everything is ok from my end. Haven't tested it locally, so I trust your tests :)

Missionframework/modules/11_permission/fnc/fn_permission_setupPlayerActions.sqf Outdated Show resolved Hide resolved
Missionframework/modules/15_build/fnc/fn_build_setupPlayerActions.sqf Outdated Show resolved Hide resolved
@Dubjunk Dubjunk merged commit 5756ea6 into v0.97S11 Mar 17, 2019
@Dubjunk Dubjunk deleted the v0.97S11-571 branch March 17, 2019 20:10
@Wyqer Wyqer added done and removed review/QA labels Mar 19, 2019
@Wyqer Wyqer mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 11
Development

Successfully merging this pull request may close these issues.
3 participants
@Dubjunk @Wyqer @veteran29