Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build System pt.4 - Persistence, Surface alignment, gui improvements #519

Merged
merged 34 commits into from
Nov 5, 2018
Merged

Build System pt.4 - Persistence, Surface alignment, gui improvements #519

merged 34 commits into from
Nov 5, 2018

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Nov 5, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #507, #505

Description:

Further development of build system

Content:

  • Align objects to surface
  • Show objects target position bounding box, changed to show icon at target area
  • Allow to place objects on surfaces like roofs
  • Add icons for dragging
  • Allow to build only in FOB area
  • Fix boats spawning at bottom of water containers
  • Object persistence

Tested on:

  • Local MP Vanilla
  • Local MP ACE
  • Dedicated MP Vanilla
  • Dedicated MP ACE

@veteran29
Improve build camera scrollwheel movement handling
2200722
@veteran29
Fix duplicate plm and adm actions
4de11cb
@veteran29
Add build_objectColor function
2aa7ba3
@veteran29
Add build_drawIconsPFH, update bb pfh header
f8e819e
@veteran29
Unfocus items list on item selection
25d276c
@veteran29
Show object icon at target drag pos
19109f2
@veteran29
Fix indentation
6023c51
@veteran29
Fix object placement misalignment due to change in common_createVehicle
a018da2
@veteran29
Reduce icons size
5f61cfb
@veteran29
Item selection logic improvements
40d0645
@veteran29
Small code cleanup
53f1e21
@veteran29
Fix object-cursor intersection detection
676256c
@veteran29
Add KP Logo 512x512 resource
fe3fb21
@veteran29
Move build dialog to screen edge, full screen height dialog
5bdc1ba
@veteran29
Clear queue after building
4ec7984
@veteran29
Fix build display after changing layout
b0a9953
@veteran29
Do not select item upon placement
cf6bb70
@veteran29
Draw current item icon under cursor
ebf45a4
@veteran29
Add "branding" to build and respawn displays
129b65c
@veteran29
Move left panel classes to KPGUI
aa4114b
@veteran29
Add common_getIcon
05d2291
@veteran29
Code and documentation cleanup, build logic and display events
47844ed
@veteran29
Improve modifier key handling
8a09e03
@veteran29
Improve item deletion selection handling
44772fb
@veteran29
Item movement events
cc4afb3
@veteran29
Object placement out of fob detection
596db73
@veteran29
Object surface alignment
0c24788
@veteran29
Fix getSaveData for empty data
608bea0
@veteran29
Basic build module save/load handling
b6b3964
@veteran29
Save only alive objects
81011cb
@veteran29 veteran29 requested a review from Wyqer November 5, 2018 02:13
@veteran29 veteran29 added this to the Sprint 7 milestone Nov 5, 2018
Wyqer
Wyqer requested changes Nov 5, 2018
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks basically good to me. Just many small documentation/formatting stuff to remember.
Good work. 👍

Missionframework/modules/01_common/fnc/fn_common_getIcon.sqf Outdated Show resolved Hide resolved
Missionframework/modules/01_common/fnc/fn_common_preInit.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_addToSelection.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_camAreaLimiter.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_camAreaLimiter.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_markArea.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_preInit.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_saveData.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_start.sqf Outdated Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_validatePosition.sqf Outdated Show resolved Hide resolved
@veteran29 veteran29 self-assigned this Nov 5, 2018
@veteran29 veteran29 merged commit dd10ca7 into v0.97S7 Nov 5, 2018
@veteran29 veteran29 deleted the v0.97S7-507 branch November 5, 2018 11:05
@Wyqer Wyqer added done and removed review/QA labels Nov 5, 2018
@Wyqer Wyqer mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

Assignees

@veteran29 veteran29

Labels
None yet
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @Wyqer