Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Civlil informant is not being registered at an FOB #807

Closed
nicoman35 opened this issue Jun 22, 2020 · 3 comments
Closed

Civlil informant is not being registered at an FOB #807

nicoman35 opened this issue Jun 22, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@nicoman35
Copy link

nicoman35 commented Jun 22, 2020

Bug report

Basic Information

Mission version: v0.96.7
Map used: Altis, but is irrelevant
Mods used: irrelevant
Dedicated or local game: Local game, but irrelevant
Source of the mission file (URL): https://github.com/nicoman35/KP-Liberation

Individual Things

Did you edit anything within the mission files?
A lot of things, but irrelevant to this bug

If yes, what did you edit exactly?
see above

Short Issue Description

When trying to bring the civil informant to an FOB, he will just stay there, without being registered at the FOB.
This is because of a missing '};' inside the script
KP-Liberation\Missionframework\scripts\client\civinformant\civinfo_escort.sqf
look here in my fork, where I corrected the bug:
nicoman35@3215fdf?diff=unified

Expected Behaviour

the civilist should be ungrouped and give information, which will never happen, because the responsible civinfo_escort.sqf will be ended without an error due to the missing };

Steps to Reproduce the Issue

irrelevant

Screenshots, Serverlog or any other helpful Information

@Wyqer Wyqer added the bug Something isn't working label Jun 22, 2020
@Wyqer Wyqer added this to the v0.96.8 milestone Jun 22, 2020
Wyqer added a commit that referenced this issue Jun 22, 2020
@Wyqer
Copy link
Member

Wyqer commented Jun 22, 2020

Creating a pull request with this one would've been easier, I guess.
Anyway, it's fixed and thanks for investigation of the issue. 👍

@Wyqer Wyqer closed this as completed Jun 22, 2020
@nicoman35
Copy link
Author

nicoman35 commented Jun 23, 2020

I would have loved to open a pull request. But my fork is now 24 commits ahead of the master, and afaik, there is no way to make a pull request including just one commit. I tried, but it wanted to pull every commit I made.
And very welcome. Glad that I found this annoying error.

@Wyqer
Copy link
Member

Wyqer commented Jun 23, 2020

I recommend to keep the master of your fork in sync, while having your group specific adjustments in an own branch. That way you can always get the updates in your fork, move them to your "play branch" and you will still be able to create "PR branches" from your fork master. That way you can always create proper PRs, if you would like to contribute anything.
Just if you think about adjusting your workflow in your fork and/or think you might contribute anything in the future via PRs.

veteran29 added a commit that referenced this issue Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants