add option to disable gatekeeper assessment in electron-osx-sign. re e…

…lectron-userland#3870
Kilian · May 27, 2019 · e306b45 · e306b45
1 parent 09dd74d
commit e306b45
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts
@@ -173,7 +173,9 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
       keychain: keychainName || undefined,
       binaries: (isMas && masOptions != null ? masOptions.binaries : macOptions.binaries) || undefined,
       requirements: isMas || macOptions.requirements == null ? undefined : await this.getResource(macOptions.requirements),
-      "gatekeeper-assess": appleCertificatePrefixes.find(it => identity!.name.startsWith(it)) != null,
+      // https://github.com/electron-userland/electron-osx-sign/issues/196
+      // will fail on 10.14.5+ because a signed but unnotarized app is also rejected.
+      "gatekeeper-assess": macOptions.gatekeeperAssess,
       "hardened-runtime": macOptions.hardenedRuntime,
     }
 

diff --git a/packages/app-builder-lib/src/options/macOptions.ts b/packages/app-builder-lib/src/options/macOptions.ts
@@ -116,6 +116,12 @@ export interface MacConfiguration extends PlatformSpecificBuildOptions {
    * @default false
    */
   readonly hardenedRuntime?: boolean
+
+  /**
+   * Whether to let electron-osx-sign validate the signing or not
+   * @default true
+   */
+  readonly gatekeeperAssess?: boolean
 }
 
 export interface DmgOptions extends TargetSpecificOptions {