Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine PR deletion to a single task #340

Closed
thatkookooguy opened this issue Apr 29, 2021 · 1 comment
Closed

Combine PR deletion to a single task #340

thatkookooguy opened this issue Apr 29, 2021 · 1 comment
Labels
released on @beta

Comments

@thatkookooguy
Copy link
Member

thatkookooguy commented Apr 29, 2021 •
edited
Loading

achievibit/server/src/engines/github.engine.ts

Line 320 in 646458d

This should later just flag the PR as closed\merged and should
be dealt with in the task that runs at the start of the week.
This way, we can just make the task also delete closed or merged prs
but give achievements for some actions we want to allow before deleting
all the data. Something like commiting to a branch with a closed pr
or re-opening a pr.
thatkookooguy added a commit that referenced this issue Apr 29, 2021
@thatkookooguy
feat(app): persist pr status and delete by it in task
aadc31b 
instead of immediatley deleting prs, we mark them with a status that should delete them in the next
task run (start of each week)

Resolves #340
k1b1b0t added a commit that referenced this issue Apr 29, 2021
@k1b1b0t
chore(release): 2.0.0-beta.14 [skip ci]
581808c 
# [2.0.0-beta.14](v2.0.0-beta.13...v2.0.0-beta.14) (2021-04-29)

### Features

* **models:** add status to pr model ([3ca3e6e](3ca3e6e))
* **app:** persist pr status and delete by it in task ([067b641](067b641)), closes [#340](#340)
k1b1b0t added a commit that referenced this issue Apr 29, 2021
@k1b1b0t
chore(release): 2.0.0-beta.14 [skip ci]
61e2f68 
# [2.0.0-beta.14](v2.0.0-beta.13...v2.0.0-beta.14) (2021-04-29)

### Features

* **models:** add status to pr model ([3ca3e6e](3ca3e6e))
* **app:** persist pr status and delete by it in task ([067b641](067b641)), closes [#340](#340)
@k1b1b0t
Copy link
Member

k1b1b0t commented Apr 29, 2021

🎉 This issue has been resolved in version 2.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thatkookooguy @k1b1b0t