Fix #2658: Properly include all headers in deployments #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeremy-lunarg
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow used to only zip files in
include/glslang/*, which does not respect subdirectories. Also includinginclude/glslang/**/*fixes this issue. If you look at the current builds, you can precisely observe this behaviour asbuild_info.hin the root directory is actually zipped. The${SUFFIX}seems to also have been blindly copied from the old CI which has no usage anymore. This workflow never worked. I fully tested this on Ubuntu 20.04 in WSL and on my macOS 13 Mac.Also, I've rewritten the GitHub workflow to also build for Windows, but is there any reason why VS 2015 is strictly required? GitHub workflow only offers VS Enterprise 2017, VS Enterprise 2019, or VS Enterprise 2022.
Fixes #2658.